adding a special instance-types string 'not-specified'

[myaser]

empty instance-types is not supported by cluster-registery. using not-specified will render karpenter node-pools without instance-type requirements

this way we can create node-pools like this

  - config_items:
      taints: nvidia.com/gpu=present:NoSchedule
      requirements: |
        - key: karpenter.k8s.aws/instance-gpu-manufacturer
          operator: In
          values: 
            - nvidia
    discount_strategy: null
    instance_types:
      - not-specified
    max_size: null
    min_size: null
    name: karpenter-gpu
    profile: worker-karpenter
  - config_items:
    discount_strategy: null
    instance_types:
      - not-specified
    max_size: null
    min_size: null
    name: karpenter-catch-all
    profile: worker-karpenter

[myaser]

👍🏻

[demonCoder95]

👍

[myaser]

👍🏻

[AlexanderYastrebov]

There are min/max builtins in go since 1.21 https://pkg.go.dev/builtin#min
so something like this

minSize := min(aws.Int64Value(asg.DesiredCapacity), aws.Int64Value(asg.MinSize))

should work