Define OnTask, OnScenario & OnPythonProgram plugin kinds #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clearer file name, less code in __init__.py (didn't really need to be there), room for additional contracts. Signed-off-by: Thibaut Le Page <[email protected]>
Allows to create other types of plugins. Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
This is revealed by running the tests. Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
Signed-off-by: Thibaut Le Page <[email protected]>
bmaher
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10.
Description
Prepare the stage for multiple plugin types and implement the three of them mentioned in #10.
Also updated TODO links from https://github.bus.zalan.do/TIP/transformer/issues/395 to #11.
Also configured integration with Travis.
Types of Changes
What types of changes does your code introduce? Keep the ones that apply:
Review
List of tasks the reviewer must do to review the PR: