Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve guidance for return code usage for (robust) create. #737

Merged
merged 11 commits into from
Aug 17, 2022

Conversation

tfrauenstein
Copy link
Member

addresses issue: #685

Copy link
Member

@tkrop tkrop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor comment.

chapters/http-requests.adoc Outdated Show resolved Hide resolved
@tkrop
Copy link
Member

tkrop commented Aug 17, 2022

👍

1 similar comment
@tfrauenstein
Copy link
Member Author

👍

@tfrauenstein tfrauenstein merged commit 1368a3f into main Aug 17, 2022
@tfrauenstein tfrauenstein deleted the tfrauenstein-patch-1 branch August 17, 2022 09:41
tkrop pushed a commit that referenced this pull request Nov 22, 2023
tkrop pushed a commit that referenced this pull request Nov 22, 2023
tkrop pushed a commit that referenced this pull request Nov 22, 2023
tkrop pushed a commit that referenced this pull request Nov 22, 2023
tkrop pushed a commit that referenced this pull request Dec 12, 2023
SmilyOrg added a commit that referenced this pull request Feb 29, 2024
* feat: improve response code guidance (#787, #762, #737)

Signed-off-by: tkrop <[email protected]>

* Add suggested changes from API guild discussion

* Apply suggestions from code review

Co-authored-by: Tronje Krop <[email protected]>

* Remove break

* Make POST section more concise with bullet points

* Integrate newer text copy into the updated bullet points

* Move bullet points relevant to single resources under single resources

---------

Signed-off-by: tkrop <[email protected]>
Co-authored-by: tkrop <[email protected]>
Co-authored-by: Miha Lunar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants