Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new rule: "SHOULD select appropriate one of date or date-time format" #808

Merged
merged 11 commits into from
May 6, 2024
Merged

Add new rule: "SHOULD select appropriate one of date or date-time format" #808

merged 11 commits into from
May 6, 2024

Conversation

vadimturkov
Copy link
Collaborator

Closing #797.

@ePaul
Copy link
Member

ePaul commented Apr 30, 2024

👍

tfrauenstein
tfrauenstein reviewed Apr 30, 2024
View reviewed changes
Copy link
Member

@tfrauenstein tfrauenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx a lot for the proposal. LGTM -- provided editorial change proposals.

chapters/data-formats.adoc Outdated Show resolved Hide resolved
chapters/data-formats.adoc Outdated Show resolved Hide resolved
chapters/data-formats.adoc Outdated Show resolved Hide resolved
chapters/data-formats.adoc Outdated Show resolved Hide resolved
chapters/data-formats.adoc Outdated Show resolved Hide resolved
chapters/data-formats.adoc Outdated Show resolved Hide resolved
vadimturkov and others added 6 commits May 2, 2024 10:01
@vadimturkov @tfrauenstein
Apply PR suggestion
2c3c1f9 
Co-authored-by: Thomas Frauenstein <[email protected]>
@vadimturkov @tfrauenstein
Apply PR suggestion
eeae5eb 
Co-authored-by: Thomas Frauenstein <[email protected]>
@vadimturkov @tfrauenstein
Apply PR suggestion
fdbcce6 
Co-authored-by: Thomas Frauenstein <[email protected]>
@vadimturkov @tfrauenstein
Apply PR suggestion
9bcaea0 
Co-authored-by: Thomas Frauenstein <[email protected]>
@vadimturkov @tfrauenstein
Apply PR suggestion
4ccba6e 
Co-authored-by: Thomas Frauenstein <[email protected]>
@vadimturkov @tfrauenstein
Apply PR suggestion
2aaae79 
Co-authored-by: Thomas Frauenstein <[email protected]>
@vadimturkov
Copy link
Collaborator Author

@tfrauenstein thanks for the suggestions. Applied.

tfrauenstein
tfrauenstein reviewed May 2, 2024
View reviewed changes
chapters/data-formats.adoc Outdated Show resolved Hide resolved
chapters/data-formats.adoc Outdated Show resolved Hide resolved
vadimturkov and others added 2 commits May 2, 2024 10:30
@vadimturkov @tfrauenstein
Apply PR suggestion
3090192 
Co-authored-by: Thomas Frauenstein <[email protected]>
@vadimturkov @tfrauenstein
Apply PR suggestion
d22102b 
Co-authored-by: Thomas Frauenstein <[email protected]>
@tfrauenstein
Copy link
Member

👍

@vadimturkov
Copy link
Collaborator Author

@ePaul you marked this PR with zally-change label, does it mean we need to adjust Zally?

@ePaul
Copy link
Member

ePaul commented May 6, 2024

@vadimturkov Hmm, that would be the meaning of this label, but looking at the text again, I don't remember anymore why I did this.

@ePaul
Copy link
Member

ePaul commented May 6, 2024

👍

@ePaul ePaul merged commit 7830b15 into zalando:main May 6, 2024
2 checks passed
@zalando-api-guidelines-bot zalando-api-guidelines-bot bot mentioned this pull request May 6, 2024
Closed
@ePaul ePaul mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfrauenstein tfrauenstein tfrauenstein left review comments

Assignees
No one assigned
Labels
guideline-change no-zally-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vadimturkov @ePaul @tfrauenstein