-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiline legend items #173
Open
chicio
wants to merge
10
commits into
zalando:master
Choose a base branch
from
chicio:multiline-legend-items
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y the width of '<number of the item>. ' string part).
bocytko
added
the
major
Major feature changes or updates, e.g. feature rollout to a new country, new API calls.
label
Nov 27, 2024
Thanks for the PR. It's a busy week for us (Cyber Week/Black Friday), so realistically I can take a look at this earliest next week. |
@bocytko sure, no problem. |
Hi @bocytko, don't forget about this MR. Thanks 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
major
Major feature changes or updates, e.g. feature rollout to a new country, new API calls.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
as discussed in #169,I tried to add multiline support for legend items with long names. I used
tspan
as discussed and some dynamic height calculations (based on the bounding box (getBBox
) +getComputedTextLength
).It works as expected. The items lines are aligned after the legend number.
There is still room for improvement, because we should be able to calculate the entire structure of the legends dynamically. Anyway for now, if a legend list of items is too long we should play with the parameters I added the previous PRs to fix the offset (in particular the legends offsets).
Attached you can find some example:
I tested it carefully, but please do all the checks that you want/need on your side, and let me know if this PR makes sense and can be useful (like the previous one).
lastminute-tech-radar-example-video-720.mov
lastminute-tech-radar-example-code.zip