Support TFHE-rs tensors #1130
Merged
Support TFHE-rs tensors #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 89833b8 | Previous: 40f575e | Ratio |
|---|---|---|---|
v0 PBS table generation |
61195691 ns/iter (± 340500) |
60987249 ns/iter (± 410510) |
1.00 |
v0 PBS simulate dag table generation |
39917079 ns/iter (± 1552216) |
39462397 ns/iter (± 265023) |
1.01 |
v0 WoP-PBS table generation |
54057038 ns/iter (± 1808306) |
53768465 ns/iter (± 2021554) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
youben11
force-pushed
the
feat/tfhers-tensor
branch
4 times, most recently
from
f519220 to
c24d34d
Compare
BourgerieQuentin
approved these changes
Nov 6, 2024
| @@ -10,9 +10,7 @@ crate-type = ["lib", "staticlib"] | |||
|
|
|||
|
|
|||
| [dependencies] | |||
| concrete-csprng = { git = "https://github.com/zama-ai/tfhe-rs.git", rev = "483a4fe", optional = true, features = [ | |||
There was a problem hiding this comment.
We will need to update to 0.10 before next release (https://github.com/zama-ai/concrete-internal/issues/902)
There was a problem hiding this comment.
Is this to let me know, or you want me to update it?
|
|
||
| // FheUint[metadata, ciphertexts[ciphertext[metadata, lwe_buffer] * n_cts]] + headers | ||
| (meta_fheuint + (meta_ct + lwe_size * 8/*u64*/) * n_cts) + 201 | ||
| // Vec[FheUint[metadata, ciphertexts[ciphertext[metadata, lwe_buffer] * n_cts]] + headers] * n_elem |
There was a problem hiding this comment.
not super safe but we can't do better I guess (wdyt @IceTDrinker @nsarlin-zama ?)
youben11
force-pushed
the
feat/tfhers-tensor
branch
from
8c8a4c3 to
51c8923
Compare
youben11
force-pushed
the
feat/tfhers-tensor
branch
from
51c8923 to
40f575e
Compare
also remove WrapperCpp as it's no longer needed
youben11
force-pushed
the
feat/tfhers-tensor
branch
from
40f575e to
89833b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.