Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing release check and test docs in concrete-python CI #1163

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fixing release check and test docs in concrete-python CI #1163

wants to merge 10 commits into from
+980 −4,743

Conversation

BourgerieQuentin
Copy link
Member

workerB

@cla-bot cla-bot bot added the cla-signed label Nov 27, 2024
@BourgerieQuentin BourgerieQuentin force-pushed the test-docs branch 23 times, most recently from eaabc46 to 0ccd780 Compare November 29, 2024 16:25
@BourgerieQuentin BourgerieQuentin force-pushed the test-docs branch 2 times, most recently from aa7cffa to bfe4f81 Compare December 4, 2024 13:50
@BourgerieQuentin BourgerieQuentin changed the title test docs Fixing release check and test docs in concrete-python CI Dec 4, 2024
@BourgerieQuentin BourgerieQuentin requested review from aPere3 and removed request for bcm-at-zama December 4, 2024 13:56
aPere3
aPere3 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@aPere3 aPere3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! Thanks a lot @BourgerieQuentin

@BourgerieQuentin BourgerieQuentin force-pushed the test-docs branch 2 times, most recently from 7f44bee to bd77f88 Compare December 6, 2024 16:47
@aPere3 aPere3 force-pushed the test-docs branch 2 times, most recently from 925573c to 991af9d Compare December 9, 2024 13:32
@youben11
Copy link
Member

The test-apidoc-up-to-date job would succeed without a configuration page, but then we would have a dead link. So we currently can't pass both commit-compliance and test-apidoc-up-to-date.

The real question however is why does the docs generation delete the configuration docs?

@youben11
Copy link
Member

I tried locally but it's too much different then the CI. However, the configuration file is generated correctly

@youben11
Copy link
Member

youben11 commented Dec 26, 2024 •
edited
Loading

I can see Failed to generate docs for module concrete.fhe.compilation.configuration: AttributeError("module 'concrete.fhe.compilation.configuration' has no attribute '__create_fn__'") here

should be related to ml-tooling/lazydocs#72

@youben11
refactor(ci): merge gpu and cpu releases
a779e20
@youben11
fix(ci/docs): change version only
aec5e30 
it was previously changing the file header which then affects the docs
@youben11 youben11 force-pushed the test-docs branch 2 times, most recently from fc40c31 to 9183954 Compare December 26, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aPere3 aPere3 aPere3 approved these changes

@youben11 youben11 Awaiting requested review from youben11

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BourgerieQuentin @youben11 @aPere3