perf(frontend/compiler): deser keyset using path instead of buffer #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youben11
force-pushed
the
fix/keyset_deser
branch
from
331d60b to
bb10d62
Compare
BourgerieQuentin
requested changes
Nov 28, 2024
|
There are no test on it? where the caller is changed? |
youben11
force-pushed
the
fix/keyset_deser
branch
from
bb10d62 to
2f0dc41
Compare
reduce memory usage by avoiding unecessary copy
youben11
force-pushed
the
fix/keyset_deser
branch
from
2f0dc41 to
6f3a0e4
Compare
There is. Those tests failed, I just "overloaded" the function (I missed that its public API anyway) to avoid breaking changes. |
BourgerieQuentin
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduce memory usage by avoiding unecessary copy