feat(hlapi): add strings #1882
Open
feat(hlapi): add strings #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmontaigu
force-pushed
the
tm/hlstrings
branch
2 times, most recently
from
9087fcf to
7f541c9
Compare
tmontaigu
force-pushed
the
tm/hlstrings
branch
from
7f541c9 to
20b34c3
Compare
Comment on lines
+70
to
+74
| pub fn try_encrypt_with_padding( | ||
| str: impl AsRef<str>, | ||
| padding: u32, | ||
| client_key: &ClientKey, | ||
| ) -> crate::Result<Self> { |
There was a problem hiding this comment.
Maybe it would be easier for the users to give the total size instead of the padding count here, so they don't have to compute it from the string size
There was a problem hiding this comment.
we could add a try_encrypt_with_fixed_sized which encrypts and padds (or trims) so that the str has the given size
|
|
||
| impl FheStringStrip<&Self> for FheAsciiString { | ||
| /// If the pattern does match the start of the string, returns a new encrypted string | ||
| /// with the specified pattern from the start, and boolean set to `true`, |
| } | ||
|
|
||
| /// If the pattern does match the end of the string, returns a new encrypted string | ||
| /// with the specified pattern from the end, and boolean set to `true`, |
|
|
||
| impl FheStringStrip<&ClearString> for FheAsciiString { | ||
| /// If the pattern does match the start of the string, returns a new encrypted string | ||
| /// with the specified pattern from the start, and boolean set to `true`, |
| } | ||
|
|
||
| /// If the pattern does match the end of the string, returns a new encrypted string | ||
| /// with the specified pattern from the end, and boolean set to `true`, |
| } | ||
| } | ||
|
|
||
| fn test_string_len_is_empty(client_key: &ClientKey) { |
There was a problem hiding this comment.
Maybe have a test where the string is actually empty ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.