Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shortint): add some flaky/failing doctests as actual tests #685

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

IceTDrinker
Copy link
Member

closes: https://github.com/zama-ai/tfhe-rs-internal/issues/323

PR content/description

  • check that those are actually failing or that they are a doctest bug
  • add _ci_run_filter so that we can easily make sure tests run in CI even if they don't have the "parameter format"

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

- check that those are actually failing or that they are a doctest bug
- add _ci_run_filter so that we can easily make sure tests run in CI even
if they don't have the "parameter format"
Copy link

@slab-ci cpu_fast_test

@tmontaigu
Copy link
Contributor

And if we see that the actual are not flaky, we remove the doctest / mark them as ignored so that they don't run ?

@IceTDrinker
Copy link
Member Author

And if we see that the actual are not flaky, we remove the doctest / mark them as ignored so that they don't run ?

Likely, and then ditch cargo doctest for our own doctest runner down the line I guess

Copy link

Pull Request has been approved 🎉
Launching full test suite...
@slab-ci cpu_test
@slab-ci cpu_integer_test
@slab-ci cpu_multi_bit_test
@slab-ci cpu_wasm_test
@slab-ci csprng_randomness_testing

@IceTDrinker IceTDrinker merged commit 8db8cb4 into main Nov 15, 2023
20 checks passed
@IceTDrinker IceTDrinker deleted the am/chore/extract-doctests-as-actual-tests branch November 15, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants