BREAKING CHANGE(all): [v16] Bump dependency package versions #926

rnegron · 2024-11-25T19:22:51Z

root (monorepo `package.json`) package updates

Major version changes

lerna: 6.4.1 -> 8.0.2 (drops Node.js 16 support, changelog)
husky: 7.0.4 -> 9.1.7 (no real breaking changes, just configuration and caller changes, changelog)
mocha: 10.8.2 -> 11.0.1 (no real breaking changes, release plan)

zapier-platform-cli package updates

Major version changes

archiver 5.3.1 -> 7.0.1: (requires Node.js 12, changelog)
gulp-prettier: 4.0.0 -> 5.0.0 (requires Node.js 16, changelog)
marked 4.2.12 -> 14.1.4 (requires Node.js 18, changelog)
- Don't think we can upgrade to v15 until marked-terminal supports it officially?
marked-terminal: 5.2.0 -> 7.2.1 (required Node.js 16, changelog)
read: 2.1.0 -> 4.0.0 (requires Node.js 18, changelog)

Minor version changes

fs-extra: 11.1.1 -> 11.2.0
yeoman-environment: 3.3.0 -> 3.19.3
semver: 7.5.2 -> 7.6.3
node-fetch: 2.6.7 -> 2.7.0

Patch version changes

@oclif/* dependencies: patch version bumps after the major version bumps performed in: [PDE-5214] chore(cli): Oclif upgraded to v4 #890
adm-zip: 0.5.10 -> 0.5.16
browserify: 17.0.0 -> 17.0.1
cli-table3: 0.6.3 -> 0.6.5
tmp: 0.2.1 -> 0.2.3
traverse: 0.6.7 -> 0.6.10

zapier-platform-core package updates

Major version changes

dotenv: 12.0.4 -> 16.4.5
- The v15 breaking change regarding comments and the v16 breaking change regarding backticks is worth highlighting in the release zapier-platform v16 notes in case it impacts anyone using zapier.tools.env.inject()

Minor version changes

semver: 7.5.2 -> 7.6.3
node-fetch: 2.6.7 -> 2.7.0

Patch version changes

form-data: 4.0.0 -> 4.0.1

Package updates ignored intentionally:

ESM Required

gulp-filter >=8 : blocked by ESM (changelog)
inquirer >=9: blocked by ESM (changelog)
yeoman-environment >= 4: blocked by ESM (changelog)
yeoman-generator >= 6: blocked by ESM (changelog)
gulp-prettier >= 6: blocked by ESM (changelog)
ora >= 6: blocked by ESM (changelog)
string-length >= 5: blocked by ESM (changelog)
update-notifier >= 6: blocked by ESM (changelog)
chai >= 5: blocked by ESM (changelog)
chalk >= 5: blocked by ESM (changelog)

Node.js Version Incompatibility

minimatch required Node.js >= 20 (changelog)

Other

parse-gitignore >= 1: there may be undocumented breaking changes (example)
ignore >= 6: v6 was published by mistake (changelog)
zapier-platform-legacy-scripting-runner dependencies: async, flat, jquery, jsdom, moment-timezone, node-fetch, synckit, underscore, xmldom.
jsonschema: >1.2.2: Updating this package to latests breaks some tests with: "no such schema </DynamicFieldsSchema>" (example CI run)
- I believe we meant to upgrade this back in v15 but it didn't seem to have happened.
prettier, eslint and related eslint packages: Will tackle in a separate MR as there are a bunch of formatting changes.

rnegron · 2024-11-26T20:23:04Z

packages/cli/src/tests/utils/build.js

@@ -57,7 +57,7 @@ describe('build (runs slowly)', function () {
    smartPaths.filter((p) => p.endsWith('.ts')).length.should.equal(0);
    smartPaths.should.not.containEql('tsconfig.json');

-    smartPaths.length.should.be.within(200, 300);
+    smartPaths.length.should.be.within(200, 301);


There is a new file: node_modules/dotenv/package.json 🤷🏻‍♂️

rnegron · 2024-11-26T21:06:05Z

packages/cli/src/oclif/commands/init.js

-    env.run('zapier:integration', { path, template }, () => {
-      this.log();
-      this.log(`A new integration has been created in directory "${path}".`);
-      this.log(`Read all about it in "${join(path, 'README.md')}".`);
-    });
+    await env.run('zapier:integration', { path, template });
+
+    this.log();
+    this.log(`A new integration has been created in directory "${path}".`);
+    this.log(`Read all about it in "${join(path, 'README.md')}".`);


Switching from callback to promises/async. Side note: this should have been broken in v3.0.0 (see last point in changelog) but enforcement was broken until v3.5.0 (see last point in changelog)

rnegron · 2024-12-02T17:28:55Z

.prettierignore

@@ -3,3 +3,5 @@ package.json
 package-lock.json
 packages/cli/src/generators/templates/
 .yarn
+
+/.nx/workspace-data


This was added automatically via lerna repair

This reverts commit 840d0ae.

This reverts commit df8a16f.

rnegron · 2024-12-03T14:15:55Z

.husky/pre-commit

-#!/bin/sh
-. "$(dirname "$0")/_/husky.sh"


Husky itself asks us to remove this 😄

rnegron · 2024-12-03T14:16:17Z

lerna.json

@@ -1,10 +1,10 @@
 {
  "npmClient": "yarn",
  "version": "independant",
-  "useWorkspaces": true,


This is now the default value and was recommended to be removed via lerna repair

kreddlear

Thank you for adding all the comments and links to relevant changelogs/release notes, and for doing all that research in the first place. This looks great!

* Param name fixed. * Width of produced markdown docs fixed to 80 chars. * Deps of @oclif packages upgraded. * Command args and flags upgraded. * Run scripts updated. * Tests for ZapierBaseCommand upgraded with command flag tests added. * Tests for register command upgraded. * logList is really printing tables (without borders). * argv parsed. * yarn lock file updated. * Docs updated. * Function name consolidated. * @oclif/core requires node >= 18. * Old code removed. * build(schema-to-ts): [PDE-5183] schema-to-ts is now part of yarn workspace (#913) * BREAKING CHANGE(all): [v16] Bump dependency package versions (#926) * bumping oclif packages * bump more packages * upgrade Yeoman enviornment to latest v3 * dotenv added a package.json * more package upgrades * use promises instead of callback * revert jsonschema upgrade as it breaks a test * bump * upgrade Lerna to v8 * upgrade prettier to latest v3 * run prettier with trailingComma: es5 * upgrade husky * husky followups * Revert "upgrade prettier to latest v3" This reverts commit 840d0ae. * Revert "run prettier with trailingComma: es5" This reverts commit df8a16f. * bump mocha, dotenv and oclif core patch * undo convert changes * chore(all): [v16] Bump eslint and related packages, bump prettier and run on codebase (#927) * bumping oclif packages * bump more packages * upgrade Yeoman enviornment to latest v3 * dotenv added a package.json * more package upgrades * use promises instead of callback * revert jsonschema upgrade as it breaks a test * bump * upgrade Lerna to v8 * upgrade prettier to latest v3 * run prettier with trailingComma: es5 * upgrade husky * husky followups * Revert "upgrade prettier to latest v3" This reverts commit 840d0ae. * Revert "run prettier with trailingComma: es5" This reverts commit df8a16f. * bump mocha, dotenv and oclif core patch * undo convert changes * bump eslint and related packages * prettier bump, run prettier * fix eslintignore * fix test * run over example-apps as well * rebuild yarn.lock * chore(types): Add type for z.request option skipEncodingChars (#928) --------- Co-authored-by: szchenghuang <[email protected]> Co-authored-by: Thomas Cranny <[email protected]>

bumping oclif packages

6ba9bcf

rnegron changed the base branch from main to zapier-platform-major-release-16.0.0-dev November 25, 2024 19:23

rnegron added 3 commits November 25, 2024 16:12

bump more packages

031c21f

upgrade Yeoman enviornment to latest v3

13dc50d

dotenv added a package.json

34b54a9

rnegron changed the title ~~chore(cli, core): Bump dependency package versions~~ chore(cli, core): [v16] Bump dependency package versions Nov 26, 2024

rnegron commented Nov 26, 2024

View reviewed changes

rnegron added 2 commits November 26, 2024 16:47

more package upgrades

f95dd7b

use promises instead of callback

a128bcb

rnegron commented Nov 26, 2024

View reviewed changes

rnegron added 5 commits December 2, 2024 09:04

revert jsonschema upgrade as it breaks a test

69f205a

bump

adf14e2

upgrade Lerna to v8

24d5c39

upgrade prettier to latest v3

840d0ae

run prettier with trailingComma: es5

df8a16f

rnegron commented Dec 2, 2024

View reviewed changes

rnegron added 5 commits December 2, 2024 13:40

upgrade husky

9a0b9ef

husky followups

8c4384d

Revert "upgrade prettier to latest v3"

3926632

This reverts commit 840d0ae.

Revert "run prettier with trailingComma: es5"

9f04ff6

This reverts commit df8a16f.

bump mocha, dotenv and oclif core patch

549acae

rnegron changed the title ~~chore(cli, core): [v16] Bump dependency package versions~~ chore(all): [v16] Bump dependency package versions Dec 3, 2024

rnegron changed the title ~~chore(all): [v16] Bump dependency package versions~~ BREAKING CHANGE(all): [v16] Bump dependency package versions Dec 3, 2024

rnegron marked this pull request as ready for review December 3, 2024 14:15

rnegron requested a review from a team as a code owner December 3, 2024 14:15

rnegron commented Dec 3, 2024

View reviewed changes

.husky/pre-commit

Comment on lines -1 to -2

#!/bin/sh

. "$(dirname "$0")/_/husky.sh"

Copy link

Member Author

rnegron Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Husky itself asks us to remove this 😄

rnegron commented Dec 3, 2024

View reviewed changes

undo convert changes

6612ca0

rnegron mentioned this pull request Dec 3, 2024

chore(all): [v16] Bump eslint and related packages, bump prettier and run on codebase #927

Merged

kreddlear approved these changes Dec 3, 2024

View reviewed changes

rnegron merged commit adb1bd9 into zapier-platform-major-release-16.0.0-dev Dec 4, 2024
14 checks passed

rnegron deleted the PDE-4097 branch December 4, 2024 12:39

rnegron mentioned this pull request Dec 4, 2024

chore(all) [PDE-4089]: v16 release development branch #923

Merged

rnegron mentioned this pull request Dec 11, 2024

[PDE-4089] chore(cli, core, schema): Release v16.0.0 #929

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BREAKING CHANGE(all): [v16] Bump dependency package versions #926

BREAKING CHANGE(all): [v16] Bump dependency package versions #926

rnegron commented Nov 25, 2024 •

edited

Loading

rnegron Nov 26, 2024

rnegron Nov 26, 2024

rnegron Dec 2, 2024

rnegron Dec 3, 2024

rnegron Dec 3, 2024

kreddlear left a comment

BREAKING CHANGE(all): [v16] Bump dependency package versions #926

BREAKING CHANGE(all): [v16] Bump dependency package versions #926

Conversation

rnegron commented Nov 25, 2024 • edited Loading

root (monorepo package.json) package updates

Major version changes

zapier-platform-cli package updates

Major version changes

Minor version changes

Patch version changes

zapier-platform-core package updates

Major version changes

Minor version changes

Patch version changes

Package updates ignored intentionally:

ESM Required

Node.js Version Incompatibility

Other

rnegron Nov 26, 2024

Choose a reason for hiding this comment

rnegron Nov 26, 2024

Choose a reason for hiding this comment

rnegron Dec 2, 2024

Choose a reason for hiding this comment

rnegron Dec 3, 2024

Choose a reason for hiding this comment

rnegron Dec 3, 2024

Choose a reason for hiding this comment

kreddlear left a comment

Choose a reason for hiding this comment

rnegron commented Nov 25, 2024 •

edited

Loading

root (monorepo `package.json`) package updates