Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDE-4089 fix(cli): fix command help markdown formatting #930

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

eliangcs
Copy link
Member

@eliangcs eliangcs commented Dec 13, 2024

The markdown formatting doesn't seem to work in the release-16.0.0 branch. This PR fixes that. The reason is that the new version of marked-terminal changes its interface that we need to adapt.


Before (15.19.0):


Before (release-16.0.0 branch currently):


After (this PR):


P.S. I don't like the extra new lines in the EXAMPLES section. Those seems to be hard-coded in the new oclif, so 🤷 .

@rnegron
Copy link
Member

rnegron commented Dec 13, 2024

Nice catch! Thanks @eliangcs 💯

@eliangcs eliangcs merged commit 970f2f6 into release-16.0.0 Dec 13, 2024
14 checks passed
@eliangcs eliangcs deleted the PDE-4089-fix-cli-help-formatting branch December 13, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants