Skip to content

Commit

Permalink
Fix store creation with latest zarr-python v3 (#644)
Browse files Browse the repository at this point in the history
* Pin most recent beta release of zarr python

* Fix store creation
  • Loading branch information
dstansby authored Nov 16, 2024
1 parent 5b8c09c commit d78cadd
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
run: |
conda activate env
# TODO: remove --pre option when zarr v3 is out
python -m pip install --pre zarr
python -m pip install --pre zarr>=3.0.0b2
# This is used to test with zfpy, which does not yet support numpy 2.0
- name: Install older numpy and zfpy
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ repos:
hooks:
- id: mypy
args: [--config-file, pyproject.toml]
additional_dependencies: [numpy, pytest, zfpy, 'zarr==3.0.0b1']
additional_dependencies: [numpy, pytest, zfpy, 'zarr>=3.0.0b2']
2 changes: 1 addition & 1 deletion .readthedocs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ build:
python: "3.12"
jobs:
post_install:
- python -m pip install --pre 'zarr'
- python -m pip install --pre 'zarr>=3.0.0b2'

sphinx:
configuration: docs/conf.py
Expand Down
2 changes: 1 addition & 1 deletion numcodecs/tests/test_zarr3.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

@pytest.fixture
def store() -> StorePath:
return StorePath(MemoryStore(mode="w"))
return StorePath(MemoryStore(read_only=False))


ALL_CODECS = [getattr(numcodecs.zarr3, cls_name) for cls_name in numcodecs.zarr3.__all__]
Expand Down

0 comments on commit d78cadd

Please sign in to comment.