-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Build linux aarch64 wheels on release #315
Open
jthetzel
wants to merge
7
commits into
zarr-developers:main
Choose a base branch
from
jvp-labs:odidev_numcodecs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
36b1a69
Add linux aarch64 wheel build support
odidev 0a368bb
Merge remote-tracking branch 'upstream/master' into odidev_numcodecs
jthetzel f6d21f4
Merge branch 'main' into odidev_numcodecs
jthetzel e4bd997
ci: Add separate aarch64 wheel build on deployment
jthetzel 6afe525
fix: Enable Python >- 3.8 aarch64 wheels
jthetzel fb49b78
docs: Add weel build to release.rst
jthetzel da9bb9e
Merge branch 'main' into odidev_numcodecs
jthetzel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,13 +4,18 @@ on: [push, pull_request] | |
|
||
jobs: | ||
build_wheels: | ||
name: Build wheel on ${{ matrix.os }} | ||
name: Build wheel on ${{matrix.arch}} for ${{ matrix.os }} | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
os: [ubuntu-latest, windows-latest, macos-latest] | ||
arch: [auto] | ||
include: | ||
- os: ubuntu-latest | ||
arch: aarch64 | ||
env: | ||
CIBW_ARCHS_LINUX: ${{matrix.arch}} | ||
CIBW_TEST_COMMAND: pytest --pyargs numcodecs | ||
CIBW_TEST_REQUIRES: pytest | ||
CIBW_SKIP: "pp*" | ||
|
@@ -24,6 +29,26 @@ jobs: | |
|
||
- uses: pypa/[email protected] | ||
|
||
- uses: docker/setup-qemu-action@v1 | ||
if: ${{ matrix.arch == 'aarch64' }} | ||
name: Set up QEMU | ||
|
||
- name: Install cibuildwheel | ||
run: | | ||
python -m pip install cibuildwheel==1.8.0 wheel | ||
|
||
- name: Build wheel for aarch64 | ||
if: ${{ matrix.arch == 'aarch64' }} | ||
env: | ||
CIBW_ENVIRONMENT: 'DISABLE_NUMCODECS_AVX2=1 DISABLE_NUMCODECS_SSE2=1' | ||
run: | | ||
python -m cibuildwheel --output-dir wheelhouse | ||
|
||
- name: Build wheel | ||
if: ${{ matrix.arch != 'aarch64' }} | ||
run: | | ||
python -m cibuildwheel --output-dir wheelhouse | ||
|
||
- uses: actions/upload-artifact@v1 | ||
with: | ||
name: wheels | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this pinning or could this be dropped?
Note: We are using the
cibuildwheel
action above. Maybe there is some way to consolidate this work into that step (possibly through additional configuration options)?