Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyclic import (numcodecs → numcodecs.pcodec) #632

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Nov 12, 2024

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (07755d1) to head (881049b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
- Coverage   99.92%   99.92%   -0.01%     
==========================================
  Files          62       62              
  Lines        2692     2691       -1     
==========================================
- Hits         2690     2689       -1     
  Misses          2        2              
Files with missing lines Coverage Δ
numcodecs/pcodec.py 100.00% <100.00%> (ø)

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review November 12, 2024 12:32
@dstansby dstansby merged commit 7523fc6 into zarr-developers:main Nov 13, 2024
26 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the PYL-R0401 branch November 13, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants