Test PR for address freezing for centrally managed tokens #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: waiting period activated by feature 14
Note: rejected after interpretation so the transactions can still be viewed
…roperty is managed
Note: includes minor comment correction
… frozen address/property
…g' transactions Note: TX71 no longer has a state. TX71 enables & TX72 disables.
Note: during some testing I picked up that while loading the freeze state at startup if there are multiple freeze/unfreeze transactions in the same block they may not be loaded in the correct order. Unlikely scanerio but we need to cover it just the same. This change just adds the tx position within the block to the sort order.
Note: addressBytes size check failed (didn't include version) so was never truncated to remove checksum. Note: also removes "unexpected size from DecodeBase58 when decoding address" erros from log.
Note: if we need to reverse a disable due to a reorg, we need to know when freezing was previously enabled to comply with waiting periods
dexX7
reviewed
Dec 9, 2017
| liveBlock = block; | ||
| } else { | ||
| const CConsensusParams& params = ConsensusParams(); | ||
| liveBlock = params.OMNI_FREEZE_WAIT_PERIOD + block; |
There was a problem hiding this comment.
Maybe I'm missing something, but can you quickly clarify what happens, if the sender wants to activate freezing at block height 1000? Does he have to send 1000-waitperiod or 1000?
There was a problem hiding this comment.
The sender doesn't have a choice in the wait period, it's defined in the consensus rules bud
Note, freezing should only affect the available balance, not prior actions The following steps could be done by anyone and would have tripped the assert: 1) List a trade from address A for prop N 2) Freeze address A for prop N 3) List a matching trade from address B
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.