Replace integration tests by official SHACL test suite #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinmaillard
force-pushed
the
official-tests
branch
from
9de787a to
37bfe89
Compare
martinmaillard
force-pushed
the
official-tests
branch
from
37bfe89 to
ba9adde
Compare
bergos
approved these changes
Apr 15, 2020
They are replaced by the official SHACL test suite
martinmaillard
force-pushed
the
official-tests
branch
from
ba9adde to
d273ecd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration tests were very similar to the official test suite, but didn't cover all the cases and weren't validated in the way that is described in https://w3c.github.io/data-shapes/data-shapes-test-suite
This PR also fixes an issue with the validation report dataset: nested blank node structures were not included in the dataset. They are now.
4 tests are currently skipped. 2 because of w3c/data-shapes#124, and 2 because the library doesn't support non-numerical datatype comparisons (#23).
I also included the SHACL-SPARQL test cases (even though they're skipped) for completeness, but I'm not sure this is necessary. I'll probably remove them.