Skip to content

Commit

Permalink
Improve timeout for GNMI dbus service (sonic-net#265)
Browse files Browse the repository at this point in the history
Why I did it
Currently we are using 60 seconds as timeout for GNMI dbus API, if GCU takes several minutes, GNMI will fail.
Microsoft ADO: 27231413

How I did it
Now we use 180 seconds as timeout, and this is the same as NDM timeout for GCU.

How to verify it
Run GNMI unit test and end to end test.
  • Loading branch information
ganglyu authored Jun 24, 2024
1 parent b1c90c9 commit a610784
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions sonic_service_client/dbus_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func (c *DbusClient) ApplyPatchYang(patch string) error {
busName := c.busNamePrefix + modName
busPath := c.busPathPrefix + modName
intName := c.intNamePrefix + modName + ".apply_patch_yang"
err := DbusApi(busName, busPath, intName, 60, patch)
err := DbusApi(busName, busPath, intName, 180, patch)
return err
}

Expand All @@ -126,7 +126,7 @@ func (c *DbusClient) ApplyPatchDb(patch string) error {
busName := c.busNamePrefix + modName
busPath := c.busPathPrefix + modName
intName := c.intNamePrefix + modName + ".apply_patch_db"
err := DbusApi(busName, busPath, intName, 60, patch)
err := DbusApi(busName, busPath, intName, 180, patch)
return err
}

Expand Down

0 comments on commit a610784

Please sign in to comment.