zcash_address: Add support for ZIP 316, Revision 1

[nuttycom]

Closes #1153.

[codecov]

Codecov Report

Attention: Patch coverage is 56.56716% with 291 lines in your changes missing coverage. Please review.

Project coverage is 53.10%. Comparing base (3a678bb) to head (38cb946).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
zcash_keys/src/keys.rs	64.86%	91 Missing ⚠️
devtools/src/bin/inspect/keys/view.rs	0.00%	60 Missing ⚠️
components/zcash_address/src/kind/unified.rs	55.46%	53 Missing ⚠️
zcash_keys/src/address.rs	53.60%	45 Missing ⚠️
...mponents/zcash_address/src/kind/unified/address.rs	85.29%	10 Missing ⚠️
...ent_backend/src/data_api/wallet/input_selection.rs	14.28%	6 Missing ⚠️
..._sqlite/src/wallet/init/migrations/ufvk_support.rs	0.00%	5 Missing ⚠️
components/zcash_address/src/kind/unified/fvk.rs	77.77%	4 Missing ⚠️
components/zcash_address/src/kind/unified/ivk.rs	77.77%	4 Missing ⚠️
devtools/src/bin/inspect/address.rs	0.00%	4 Missing ⚠️
... and 4 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1135      +/-   ##
==========================================
- Coverage   53.23%   53.10%   -0.14%     
==========================================
  Files         168      168              
  Lines       20945    21276     +331     
==========================================
+ Hits        11150    11298     +148     
- Misses       9795     9978     +183     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nuttycom]

Returning to draft status to update the parsing of the HRP for ZIP 316, Revision 1

[daira]

Some changes needed — see the "(blocking)" comments.

[str4d]

Reviewed 7852a31.

[str4d]

(Just picking this test as an example)

I'm a little unhappy about the lack of Revision 1 tests. I think we'll be fine for now (particularly if my earlier suggestion to generate arbitrary revisions for proptests is accepted), but please open an issue for expanding testing to cover revision 1.

[nuttycom]

Opened #1647

[daira]

I actually think it's essential to have tests covering the differences between R0 and R1 (for example, tests that a single transparent Receiver is allowed for R1 but not for R0).

[nuttycom]

force-pushed to address comments from code review.

[daira]

utACK with comments. (Note that I was tired by the end of the review so it might not be as thorough as usual.)

[nuttycom]

force-pushed to rebase on main & fix conflicts with no_std changes.

Then force-pushed to take into account review suggestions.