Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ziggy language extension #1735

Merged
merged 7 commits into from
Dec 3, 2024
Merged

Conversation

lvignoli
Copy link
Contributor

@lvignoli lvignoli commented Dec 1, 2024

Ziggy support for Zed.

The LSP cannot be installed because of an upstream issue: releases for ziggy are distributed as tar.xz, not tar.gz.
As I understand, Zed extension SDK does not support this compression format.

Linked issues:

Copy link
Member

@notpeter notpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we know that the download/extraction will fail, can we:

  1. comment out that code
  2. require users to manually download and install ziggy into their PATH
  3. output an error when which fails to find the ziggy binary?

@notpeter notpeter self-assigned this Dec 2, 2024
@lvignoli
Copy link
Contributor Author

lvignoli commented Dec 3, 2024

@notpeter indeed, that's much sounder. Is this the proper way to do so?

@notpeter notpeter merged commit 1ab7941 into zed-industries:main Dec 3, 2024
3 checks passed
@notpeter
Copy link
Member

notpeter commented Dec 3, 2024

Thanks!

@notpeter notpeter changed the title Add ziggy Add ziggy language extension Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants