Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cmake submodule to fix Zeek configure failures with FETCHCONTENT_FULLY_DISCONNECTED flag #419

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Update cmake submodule to fix Zeek configure failures with FETCHCONTENT_FULLY_DISCONNECTED flag #419

merged 3 commits into from
Jul 12, 2024

Conversation

timwoj
Copy link
Member

@timwoj timwoj commented Jul 12, 2024

This also updates the broker CI setup to use the same flag.

@timwoj timwoj marked this pull request as ready for review July 12, 2024 21:03
ckreibich
ckreibich approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@ckreibich ckreibich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I saw caveats about the use of this flag over in the docs but since we'll have to see whether we keep any of this anyway, and it fixes things for the moment, I think this is the way to go for now.

@timwoj timwoj force-pushed the topic/timw/fetchcontent_mkdir branch from 1ddb659 to 8d9de52 Compare July 12, 2024 21:43
@timwoj timwoj merged commit 4d19d25 into master Jul 12, 2024
19 checks passed
@timwoj timwoj deleted the topic/timw/fetchcontent_mkdir branch July 12, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckreibich ckreibich ckreibich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timwoj @ckreibich