Merge #129

129: ignore probes for jobs r=zegl a=sstarcher This is an obvious extension of the original idea that somehow I forgot. Co-authored-by: Shane Starcher <[email protected]>
zegl · May 26, 2019 · bdb07f1 · bdb07f1
2 parents b6dd1bf + 6b4626a
commit bdb07f1
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/score/probes/probes.go b/score/probes/probes.go
@@ -19,7 +19,7 @@ func Register(allChecks *checks.Checks, services ks.Services) {
 // containerProbes takes a slice of all defined Services as input.
 func containerProbes(allServices []corev1.Service) func(corev1.PodTemplateSpec, metav1.TypeMeta) scorecard.TestScore {
 	return func(podTemplate corev1.PodTemplateSpec, typeMeta metav1.TypeMeta) (score scorecard.TestScore) {
-		if typeMeta.Kind == "CronJob" && typeMeta.GroupVersionKind().Group == "batch" {
+		if typeMeta.Kind == "CronJob" && typeMeta.GroupVersionKind().Group == "batch" || typeMeta.Kind == "Job" && typeMeta.GroupVersionKind().Group == "batch" {
 			score.Grade = scorecard.GradeAllOK
 			return score
 		}