Rough dynamic collision setup #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robojumper
commented
Sep 13, 2024
| public: | ||
| /* 0x00 */ mVec3_c mCenter; | ||
| /* 0x0C */ f32 mRadius; | ||
| /* 0x10 */ f32 field_0x10; |
There was a problem hiding this comment.
I don't know why a sphere is characterized by another float in additon to the radius.
| mVec3_c b = *mRail.getPntPosForIndex(0); | ||
| mVec3_c c = *mRail.getPntPosForIndex(1); | ||
|
|
||
| fn_80337EF0(&unk, b, c, scale.x * 100.0f); | ||
| f32 d; | ||
| if (fn_8032BFB0(&unk, a, q, d, 0)) { | ||
| if (cM3d_Len3dSqPntAndSegLine(&unk, a, &q, &d, nullptr)) { |
There was a problem hiding this comment.
This is evidence the old cM3d code still uses vector types that aren't mVec3_c - this creates copies of the vector with implicit copy constructors (using GPRs rather than FPRs).
There was a problem hiding this comment.
What I find more interesting is the address of it. its already closer to the Collision code and is disconnected from the m code. I think it is safe to it was a minimal effort port xD
Comment on lines
+26
to
+34
| mVec3_c mMin; | ||
| mVec3_c mMax; |
There was a problem hiding this comment.
mVec3_c here and below is an unfounded assumption.
robojumper
force-pushed
the
collision
branch
from
ce819b0
to
942f4ce
Compare
robojumper
force-pushed
the
collision
branch
from
66850aa
to
170c159
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely based on TP code - since SComponent has been absorbed by other libraries there's no longer a split between cCcd and dCcd so all names are made up again, but this matches the vtables and multiple inheritance stuff and allows us to match some simple actors with collision \o/