-
-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flickering in Nushell when used with Zellij and WezTerm #2794
Comments
Hey, thanks for the report! Zellij - still being pre 1.0 - is unfortunately not a 60fps application. While we have optimized many parts of the application to often be even faster than when running in a bare terminal (eg. dumping large amounts of text into a terminal), other parts such as these still need some attention. Due to the limited number of working hands though, these issues are not a priority (eg. over things like bugs, core features such as session resurrection, a windows version and a web client). Which is to say - this is the way things are going to be for the near future. I plan on addressing these before we release a 1.0. |
I'm seeing this same behaviour using pw-top (pipewire's monitoring app). No nushell involved, and using foot as the terminal - so it's not wezterm or nushell, this app is the commonality between these same behaviours. Every second, it updates, and flickers. I'm afraid that's a deal-breaker for me, it's a migraine and epilepsy trigger. The front page should probably carry a health warning until you've got this sorted out. |
@pallaswept - while I can empathize and am sorry this causes you discomfort, this is not necessarily the same issue and until I see a reproduction with logs as mentioned in the issue template, I would also not necessarily say this is a Zellij issue. People have a tendency to pile up on these issues, making them far less likely to be addressed due to the chaos this causes. If you'd like to help out, please open a separate issue with a reproduction as mentioned in the issue template - otherwise I would encourage you to use or not use whichever software makes you happy. |
Totally, my bad... but it's not a matter of discomfort, it's a health risk, and for some, it can be life-threatening.
Given that this exclusively occurs in zellij,not tmux or anything else, and happens in zellij, across foot, kitty, and konsole, I'm pretty confident that zellij is the issue here. I've reproduced it (while avoiding looking at the screen) and created a new issue here: #2828 But there's nothing in the logs of note, I'm afraid.
You're quite right, so I have done so.
Yeh I'm going to have to use tmux, which doesn't make me happy, I preferred zellij (this bug aside). It's not a matter of happiness, it's a matter of physical health. Seizures are serious man, if you're not familiar with it (you're a programmer not a Doctor, no shame in that) you should look it up in your favourite search engine so you understand what's at play here. Since you know this app has flickering issues and now you know it's for real dangerous, empathy is nice.... but a warning is appropriate. "I'm really sorry about your legs" are polite words but don't make up for it if you put a big hole in the ground and don't put a fence around it, ya know what I mean? 😆 |
I am very sorry for your experience and will do my best to address the issue and understand it better. |
@imsnif, I would be interested in taking a look at this. If you have an inkling of the area of code this might reside in, or what logs to pay attention to, that would be helpful. |
Well, that's a pretty good inkling! Did it indeed fix the problem, @pallaswept ? I see it's merged into main, but perhaps that hasn't been cut as a release yet? |
Good point, it hasn't actually made it into a release yet. The latest release was November 29, but this patch wasn't merged until December 3... I'm not sure if it actually fixed it, I haven't actually tested it (I'm not using a multiplexer at all at present, just waiting on a few other feature requests to make it all work together), but I did look at the code and I'm sure that for any terminal that supports synced output, that will do the job. I guess, to be really sure, I/we would have to build from source, or wait for the next release of zellij... But I'm pretty confident that change should do the trick, so I was going to just wait it out. If you're a dev who was willing to try and fix this up, I guess I don't need to offer my help building from source if you want to test it, but the offer is there nonetheless, should you need it :) |
Is there an easy way to reproduce this? I'm also experiencing this issue severely with I tried nushell, but I don't really see any severe flickers. If there's a more predictable way of reproducing the issue, I'd like to test that PR. |
This may be fixed by #3884. |
When e.g. displaying completions over a certain length, the output form Nushell will flicker under Zellij when used in WezTerm.
This does not happen when using Nushell directly under WezTerm (see below)
With Zellij:
Screen.Recording.2023-09-18.at.14.15.54.mov
Without Zellij:
Screen.Recording.2023-09-18.at.14.16.27.mov
I'm using Zellij WezTerm and Nushell under Nix (darwin).
Possibly Related:
nushell/nushell#9279
nushell/nushell#6214
Log:
Basic information
zellij --version
:zeelij 0.38.2
stty size
:97 318
uname -av
orver
(Windows):Darwin {{HOSTNAME}} 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul 5 22:22:05 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T6000 arm64 arm Darwin
List of programs you interact with as,
PROGRAM --version
: output cropped meaningful, for example:wezterm --version
:wezterm 20230712-072601-f4abf8fd
nu --version
:0.84.0
The text was updated successfully, but these errors were encountered: