Fix Synchronized Output (mode 2026) reporting #3884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The response to the 2026 mode query was missing a `?` character. The response should be of the format `CSI ? 2026 ; N $ y` where N can be any value in the range 0-4 inclusive. References: https://gist.github.com/christianparpart/d8a62cc1ab659194337d73e399004036 https://vt100.net/docs/vt510-rm/DECRPM.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for Zellij!
I help maintain Textual and some dependent TUI apps like Posting which make use of mode 2026.
I started using Zellij yesterday (loving it!) and noticed that the mode 2026 query response was not being parsed as expected and so the output could not be synchronized.
Looking into the code of Zellij, I think the response is missing a
?character. If I'm understanding correctly, response should be of the formatCSI ? 2026 ; N $ ywhere N can be any value in the range 0-4 (inclusive).References:
Before
Notice the tearing effect as the cursor moves through the list. It's particularly noticeable as the cursor moves over
PATCH.zellij-before-mode2026__85pct_smaller.mp4
After
On a build containing this fix I cannot reproduce the tearing effect:
zellij-mode2026-enabled__85pct_smaller.mp4
Possibly fixes #2794