fix(themes): fix text selection color for nightfox #3450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bg is used as text background color for selection instead of the background color of the zellij itself - this non-conventional naming confuses theme contributors and the user sees no highlight on selection - this commit updates the selection color for nightfox theme and adds missing variations of the theme - refer EdenEast/nightfox.nvim#444 Signed-off-by: Avinal Kumar <[email protected]>
|
This issue exists in other themes as well. There is a need to check them or change this convention. At least this needs to be documented somewhere so that theme contributors can put the right colors. |
|
Changes to the theme definition are expected at some point, #3242 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
the background color of the zellij itself
sees no highlight on selection
missing variations of the theme
Signed-off-by: Avinal Kumar [email protected]