fix(tab): focus largest pane instead of topmost #3795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple Panes have the same x coord in a MoveTabOrFocus event that switches tabs, instead of picking the pane at the top to focus, choose the one biggest one. This ensures that in stacked layouts, the focused pane is opened again when moving, instead of always focusing the top pane. closes zellij-org#3006
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple Panes have the same x coord in a
MoveTabOrFocusevent that switches tabs, instead of picking the pane at the top to focus, choose the one biggest one. This ensures that in stacked layouts, the focused pane is opened again when moving, instead of always focusing the top pane.Current Behaviour
When switching tabs in
MoveTabOrFocus, pick the one at the border, if multiple, pick the topmost.Fixed Behaviour
When switching tabs in
MoveTabOrFocus, pick the one at the border, if multiple, pick the largest, then the topmost.This ensures that when stacked panes are used, the previously focused is once again focused instead of always using the first.
Considerations
This should not influence existing workflows using normal tiled panes all to much, since the previous implementation was quite arbitrary anyway, but is a big fix for stacked layouts, since this "keeps the layout" instead of resetting.
closes #3006