Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

my changes #3807

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

my changes #3807

wants to merge 1 commit into from

Conversation

sivangitc
Copy link

No description provided.

@Lockszmith-GH
Copy link

Lockszmith-GH commented Nov 24, 2024

Hello @sivangitc,
Welcome to the community, and thank you for sharing your work.

I'll be straight forward, in the effort of saving yours (and other maintainers) time, by first asking the following questions:

What is the purpose of this PR?
Have you read CONTRIBUTING.md and it's linked references?

Why I'm asking?
I am no code contributor myself, but I've been around here for a while now, and I can attest, that PRs which are about critical issues or serve the overall roadmap and follow the CONTRIBUTING document (mentioned above) are more than welcome, but if they are not, they will either be ignored or closed.

I'd really want your experience to be overall a positive one, as you seem to care about the project and contribute. The questions are designed to make sure the project gets what it needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants