Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set hide_floating_panes in parse_tab_node_with_template #3846

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

zhyuri
Copy link

@zhyuri zhyuri commented Dec 6, 2024

Fixes #2974

Problem

When a layout has both default_tab_template and tabs with hide_floating_panes options, the hide_floating_panes is ignored.

Proposal

The change enables two features,

  1. [fix] The hide_floating_panes option on the tab is respected when the layout sets default_tab_template.
  2. [feat] The user can also set hide_floating_panes on default_tab_template which populates to all tabs.

Note: the hide_floating_panes on each tab takes precedence over the hide_floating_panes on the default_tab_template

Test

I reproduced the bug with the following layout from #2974 (comment) and verified the PR fixes the issue.

layout {
    default_tab_template {
        pane size=1 borderless=true {
            plugin location="zellij:tab-bar"
        }
        children
        pane size=2 borderless=true {
            plugin location="zellij:status-bar"
        }
    }

    tab hide_floating_panes=true {
        pane
        floating_panes {
            pane {
                x "10%"
                y "10%"
                width "80%"
                height "80%"
            }
        }
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hide_floating_panes doesn't work with a default_tab_template
1 participant