Set hide_floating_panes in parse_tab_node_with_template #3846
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2974
Problem
When a layout has both
default_tab_template
and tabs withhide_floating_panes
options, thehide_floating_panes
is ignored.Proposal
The change enables two features,
hide_floating_panes
option on the tab is respected when the layout setsdefault_tab_template
.hide_floating_panes
ondefault_tab_template
which populates to all tabs.Note: the
hide_floating_panes
on each tab takes precedence over thehide_floating_panes
on thedefault_tab_template
Test
I reproduced the bug with the following layout from #2974 (comment) and verified the PR fixes the issue.