DEVEX-86 Fix Docker blocking on start #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Startup process was hanging forever and it looked like Docker was responsible. We dug into the Docker API gem which looked like it was using Excon. It looked like it was using a blocking connection, so we pass 'nonblock' option to unblock it. https://github.com/excon/excon/search\?utf8\=%E2%9C%93\&q\=nonblock\&type\= https://spin.atomicobject.com/2013/09/30/socket-connection-timeout-ruby/ http://www.mikeperham.com/2009/03/15/socket-timeouts-in-ruby/ upserve/docker-api#515
grosser
force-pushed
the
gurney/dockerInvestigation
branch
from
8f5e5d3 to
2dd59cb
Compare
jonmoter
approved these changes
Feb 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Startup process was hanging forever and it looked like Docker was responsible. We dug into
the Docker API gem which looked like it was using Excon. It looked like it was using a
blocking connection, so we pass 'nonblock' option to unblock it.
https://github.com/excon/excon/search\?utf8\=%E2%9C%93\&q\=nonblock\&type\=
https://spin.atomicobject.com/2013/09/30/socket-connection-timeout-ruby/
http://www.mikeperham.com/2009/03/15/socket-timeouts-in-ruby/
upserve/docker-api#515
@jonmoter