Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinctrl: SAMx7x: Fix incorrect pinctrl config for pa21 #36

Conversation

mcscholtz
Copy link
Contributor

The pinctrl configuration for SAMx7x SOC pa21 is incorrect. Instead of afe1_ad1 it should be afe0_ad1.

This updates the pinconfigs yml file and all the updated header files.

See the associated datasheet section:

image

The pinctrl configuration for SAMx7x SOC pa21 is incorrect. Instead of afe1_ad1 it should be afe0_ad1.

This updates the pinconfigs yml file and all the updated header files.

Signed-off-by: Marius Scholtz <[email protected]>
@nandojve
Copy link
Member

Hi @mcscholtz ,

Thank you for fixing this. Where is the Zephyr side to update hal ?
It should be linked here.

@mcscholtz
Copy link
Contributor Author

@nandojve I was under the impression it needs to be merged before creating the Zephyr PR to update west.yml?

Or do I update it to commit: 122f969 and create a PR for that?

@nandojve
Copy link
Member

@nandojve I was under the impression it needs to be merged before creating the Zephyr PR to update west.yml?

No, you need create PR in Zephyr to pass CI. When you open the PR you need replace the current hash code by pull/36/head. If CI is green (in this case will be) we merge the PR 36 here. After that you update the Zephyr counter part with the new hash and get the approvals.

Since this is a simple update hal case, you can a PR in Zephyr to sync hal_atmel only, for instance:

commit 812187a87f3f056c1052b7a5cd64d0a942e2a488
Author: Keith Packard <[email protected]>
Date:   Thu Mar 30 10:16:22 2023 -0700

    west.yml: update hal_atmel to include picolibc compat fix
    
    This update removes the LITTLE_ENDIAN/__LITTLE_ENDIAN defines in all of the
    chip-specific headers as those conflict with usage of these macros in
    picolibc.
    
    Signed-off-by: Keith Packard <[email protected]>

If it is necessary to update anything here I'll ask you to send the update here before open the Zephyr PR.

I hope it is more clear now, otherwise, let me know.

@mcscholtz
Copy link
Contributor Author

@nandojve Thank you for the explanation

I created the PR, looks like the bot already linked it here

@nandojve nandojve merged commit b0cc87f into zephyrproject-rtos:master Dec 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants