drivers: wifi: nrfwifi: Enable variable network configurations #78852
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
jukkar,
Kludentwo,
krish2718,
pdgendt,
rlubos,
ssharks and
tbursztyka
sachinthegreen
previously approved these changes
Sep 25, 2024
jukkar
previously approved these changes
Sep 26, 2024
|
It seems that |
D-Triveni
force-pushed
the
variable-network-buffers
branch
from
8b056b8
to
836a25b
Compare
krish2718
reviewed
Sep 27, 2024
krish2718
reviewed
Sep 27, 2024
D-Triveni
force-pushed
the
variable-network-buffers
branch
from
836a25b
to
835eadf
Compare
sachinthegreen
previously approved these changes
Oct 8, 2024
krish2718
reviewed
Oct 8, 2024
D-Triveni
force-pushed
the
variable-network-buffers
branch
from
835eadf
to
a32d6d2
Compare
sachinthegreen
previously approved these changes
Oct 17, 2024
jukkar
previously approved these changes
Oct 17, 2024
krish2718
reviewed
Oct 17, 2024
krish2718
pushed a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
…leo_h723zg target Enable fixed data buffers for nucleo_h723zg target to prevent RAM overflows with variable network buffers usage. Upstream PR: zephyrproject-rtos/zephyr#78852 Signed-off-by: Triveni Danda <[email protected]>
Update kconfig choice name to enable overriding from other parts of the code. Signed-off-by: Triveni Danda <[email protected]>
krish2718
dismissed stale reviews from sachinthegreen and themself
via
87bef88
krish2718
force-pushed
the
variable-network-buffers
branch
from
df0d1be
to
87bef88
Compare
|
Remove adding another abstraction over networking stack, and also removed overrides for highest throughput as they impact all samples/applications RAM usage. |
Add variable network configuration control into the driver to optimize RAM usage by default. The pool sizes are default, and tuning is left to the applications or samples. Signed-off-by: Triveni Danda <[email protected]>
krish2718
force-pushed
the
variable-network-buffers
branch
from
87bef88
to
f2f49e0
Compare
krish2718
pushed a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 23, 2024
Update kconfig choice name to enable overriding from other parts of the code. Upstream PR: zephyrproject-rtos/zephyr#78852 Signed-off-by: Triveni Danda <[email protected]>
krish2718
pushed a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 23, 2024
…urations Add variable network configuration control into the driver to optimize RAM usage by default. The pool sizes are default, and tuning is left to the applications or samples. Upstream PR: zephyrproject-rtos/zephyr#78852 Signed-off-by: Triveni Danda <[email protected]>
krish2718
pushed a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 23, 2024
Update kconfig choice name to enable overriding from other parts of the code. Upstream PR: zephyrproject-rtos/zephyr#78852 Signed-off-by: Triveni Danda <[email protected]>
krish2718
pushed a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 23, 2024
…urations Add variable network configuration control into the driver to optimize RAM usage by default. The pool sizes are default, and tuning is left to the applications or samples. Upstream PR: zephyrproject-rtos/zephyr#78852 Signed-off-by: Triveni Danda <[email protected]>
krish2718
pushed a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 23, 2024
Update kconfig choice name to enable overriding from other parts of the code. Upstream PR: zephyrproject-rtos/zephyr#78852 Signed-off-by: Triveni Danda <[email protected]>
krish2718
pushed a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 23, 2024
…urations Add variable network configuration control into the driver to optimize RAM usage by default. The pool sizes are default, and tuning is left to the applications or samples. Upstream PR: zephyrproject-rtos/zephyr#78852 Signed-off-by: Triveni Danda <[email protected]>
krish2718
pushed a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 24, 2024
Update kconfig choice name to enable overriding from other parts of the code. Upstream PR: zephyrproject-rtos/zephyr#78852 Signed-off-by: Triveni Danda <[email protected]>
krish2718
pushed a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 24, 2024
…urations Add variable network configuration control into the driver to optimize RAM usage by default. The pool sizes are default, and tuning is left to the applications or samples. Upstream PR: zephyrproject-rtos/zephyr#78852 Signed-off-by: Triveni Danda <[email protected]>
jukkar
approved these changes
Oct 24, 2024
krish2718
pushed a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 24, 2024
Update kconfig choice name to enable overriding from other parts of the code. Upstream PR: zephyrproject-rtos/zephyr#78852 Signed-off-by: Triveni Danda <[email protected]>
krish2718
pushed a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 24, 2024
…urations Add variable network configuration control into the driver to optimize RAM usage by default. The pool sizes are default, and tuning is left to the applications or samples. Upstream PR: zephyrproject-rtos/zephyr#78852 Signed-off-by: Triveni Danda <[email protected]>
rlubos
pushed a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
Update kconfig choice name to enable overriding from other parts of the code. Upstream PR: zephyrproject-rtos/zephyr#78852 Signed-off-by: Triveni Danda <[email protected]>
rlubos
pushed a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
…urations Add variable network configuration control into the driver to optimize RAM usage by default. The pool sizes are default, and tuning is left to the applications or samples. Upstream PR: zephyrproject-rtos/zephyr#78852 Signed-off-by: Triveni Danda <[email protected]>
rlubos
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
Update kconfig choice name to enable overriding from other parts of the code. Upstream PR: zephyrproject-rtos/zephyr#78852 Signed-off-by: Triveni Danda <[email protected]>
rlubos
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
…urations Add variable network configuration control into the driver to optimize RAM usage by default. The pool sizes are default, and tuning is left to the applications or samples. Upstream PR: zephyrproject-rtos/zephyr#78852 Signed-off-by: Triveni Danda <[email protected]>
NordicBuilder
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
Update kconfig choice name to enable overriding from other parts of the code. Upstream PR: zephyrproject-rtos/zephyr#78852 Signed-off-by: Triveni Danda <[email protected]> (cherry picked from commit cbcb2db)
NordicBuilder
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
…urations Add variable network configuration control into the driver to optimize RAM usage by default. The pool sizes are default, and tuning is left to the applications or samples. Upstream PR: zephyrproject-rtos/zephyr#78852 Signed-off-by: Triveni Danda <[email protected]> (cherry picked from commit b58ca22)
rlubos
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
Update kconfig choice name to enable overriding from other parts of the code. Upstream PR: zephyrproject-rtos/zephyr#78852 Signed-off-by: Triveni Danda <[email protected]> (cherry picked from commit cbcb2db)
rlubos
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 25, 2024
…urations Add variable network configuration control into the driver to optimize RAM usage by default. The pool sizes are default, and tuning is left to the applications or samples. Upstream PR: zephyrproject-rtos/zephyr#78852 Signed-off-by: Triveni Danda <[email protected]> (cherry picked from commit b58ca22)
|
@D-Triveni this needs to be rebased please |
|
@kartben These changes were pulled into another PR and merged, so, this one is being closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a name to the existing Kconfig choice for better clarity. Add variable network configuration control into the driver, removing the need for per-sample settings.