Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Beautify devicetree macro #82094

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rruuaanng
Copy link
Collaborator

@rruuaanng rruuaanng commented Nov 27, 2024

This makes the preprocessor macros in dts/common more beautiful, in line with the ZEPHYR_INCLUDE macro style, and it reuses the existing DT_xxx_K instead of hard coding.

Change '(x) * num_constant' to reuse DT_xxx_K macro.

Signed-off-by: James Roy <[email protected]>
Pre-macros to beautify 'freq.h' and 'mem.h'
in 'dts/common'.

Signed-off-by: James Roy <[email protected]>
@kartben
Copy link
Collaborator

kartben commented Nov 27, 2024

The second commit message looks wrong? Rather than beautifying, this is expanding the name of the include guards to avoid potential clash

@rruuaanng
Copy link
Collaborator Author

Good catch. I'll modify it later.
(In fact, it makes me confused about how to describe it. I think it seems to be more beautiful.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants