Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 9 update #58

Closed
wants to merge 2 commits into from
Closed

Laravel 9 update #58

wants to merge 2 commits into from

Conversation

ruaq
Copy link

@ruaq ruaq commented May 27, 2022

added support for Laravel 9.x

solves #56

@waqleh
Copy link

waqleh commented May 31, 2022

can someone merge this and create a new tag?

@eartahhj
Copy link

As of today I can't install the package on Laravel 9 with composer require zerospam/laravel-gettext because it will return this error:

- Root composer.json requires zerospam/laravel-gettext ^8.0 -> satisfiable by zerospam/laravel-gettext[8, 8.0.1, 8.0.2].
- zerospam/laravel-gettext[8, ..., 8.0.2] require laravel/framework ^6.0 || ^7.0 || ^8.0 -> found laravel/framework[v6.0.0, ..., 6.x-dev, v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev] but it conflicts with your root composer.json require (^9.19).

I guess I could manually fix it somehow but I'd rather wait for official compatibility to avoid problems.

@aaronmeder
Copy link

Would be great if this could be merged...we're also upgrading our app to Laravel 9 and this is blocking the process atm.

Any Updates on this? @zerospam

@frizikk
Copy link

frizikk commented Sep 11, 2022

Any Updates on this? @zerospam

@netbbe
Copy link

netbbe commented Oct 7, 2022

Any updates on this? @zerospam

2 similar comments
@DjeboDigital
Copy link

Any updates on this? @zerospam

@KamilMerkandi
Copy link

Any updates on this? @zerospam

@RonJeremyR6
Copy link

How can I 'composer require' these changes? I am not very well known into Github.
@ruaq ?

@ruaq
Copy link
Author

ruaq commented Nov 29, 2022

How can I 'composer require' these changes?

My workaround was to change my composer.json

from

"require": {
        "zerospam/laravel-gettext": "^8.0"
    },

to

"repositories": [
        {
            "type": "git",
            "url": "https://github.com/prevplan/laravel-gettext"
        }
    ],
"require": {
        "zerospam/laravel-gettext": "dev-patch-1"
    },

See https://github.com/prevplan/courserv.io/commit/989dec992174bd1543f920c1aa329629e33d8d5f#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34 for example.

@evifere
Copy link

evifere commented Jan 4, 2023

any update on this ?

@ruaq
Copy link
Author

ruaq commented Jan 4, 2023

Since my temp workaround is nearly a year old, there wasn’t a reaction in any kind of @zerospam neither here nor anywhere else in the repos and Laravel 10 is already on the horizon, I would offer to fork it entirely and release a working version for composer.

Opinions? Other offers?

@eartahhj
Copy link

eartahhj commented Jan 4, 2023

I guess the alternative would be to just configure the default gettext without using this package, maybe the only issue could rise when trying to parse blade views where u use for example {{ _('String') }}, xgettext and msgfmt might not be able to get it.
You could try something like this: Generating PO files with Laravel & translating Blade templates
And for local environment I can suggest my gettext guide for Windows

@ruaq
Copy link
Author

ruaq commented Jan 8, 2023

@nekhbet has also forked it and will maintain it for its own longtime projects. So I’ll change to this fork.
See comment #56 (comment) and repo https://github.com/nekhbet/laravel-gettext

@ruaq ruaq closed this Jan 8, 2023
@ruaq ruaq mentioned this pull request Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants