Skip to content

final cleaning

This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Advanced Security / CodeQL failed Sep 28, 2023 in 10s

59 new alerts including 13 errors

New alerts in code changed by this pull request

  • 13 errors
  • 7 warnings
  • 39 notes

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 44 in src/sisl/nodes/node.py

See this annotation in the file changed.

Code scanning / CodeQL

`__eq__` not overridden when adding attributes Warning

The class 'Node' does not override
'__eq__'
, but adds the new attribute
_inputs
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_input_nodes
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_output_links
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_prev_evaluated_inputs
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_output
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_nupdates
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_outdated
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_errored
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_error
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_logger
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_log_formatter
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
logs
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
context
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_cls_context
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
context
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_known_function_nodes
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
__doc__
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_args_inputs_key
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_kwargs_inputs_key
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_args_inputs_key
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_kwargs_inputs_key
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
__signature__
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_output
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_errored
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_error
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_prev_evaluated_inputs
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_outdated
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute
_errored
.
The class 'Node' does not override
'__eq__'
, but adds the new attribute _error.
The class 'Node' does not override
'__eq__'
, but adds the new attribute _outdated.
The class 'Node' does not override
'__eq__'
, but adds the new attribute _errored.

Check failure on line 181 in src/sisl/viz/data/bands.py

See this annotation in the file changed.

Code scanning / CodeQL

Non-callable called Error

Call to a
non-callable
of
class BandsData
.

Check failure on line 236 in src/sisl/viz/data/bands.py

See this annotation in the file changed.

Code scanning / CodeQL

Non-callable called Error

Call to a
non-callable
of
class BandsData
.

Check failure on line 18 in src/sisl/viz/data/eigenstate.py

See this annotation in the file changed.

Code scanning / CodeQL

Non-callable called Error

Call to a
non-callable
of
class EigenstateData
.

Check failure on line 23 in src/sisl/viz/data/eigenstate.py

See this annotation in the file changed.

Code scanning / CodeQL

Non-callable called Error

Call to a
non-callable
of
class EigenstateData
.

Check failure on line 95 in src/sisl/viz/data/pdos.py

See this annotation in the file changed.

Code scanning / CodeQL

Non-callable called Error

Call to a
non-callable
of
class PDOSData
.

Check warning on line 326 in src/sisl/viz/figure/matplotlib.py

See this annotation in the file changed.

Code scanning / CodeQL

Signature mismatch in overriding method Warning

Overriding method 'set_axis' has signature mismatch with
overridden method
.

Check warning on line 544 in src/sisl/viz/figure/plotly.py

See this annotation in the file changed.

Code scanning / CodeQL

Signature mismatch in overriding method Warning

Overriding method 'set_axis' has signature mismatch with
overridden method
.

Check failure on line 109 in src/sisl/viz/figure/figure.py

See this annotation in the file changed.

Code scanning / CodeQL

Modification of parameter with default Error

This expression mutates a
default value
.

Check failure on line 584 in src/sisl/viz/figure/figure.py

See this annotation in the file changed.

Code scanning / CodeQL

Modification of parameter with default Error

This expression mutates a
default value
.

Check failure on line 156 in src/sisl/viz/data/pdos.py

See this annotation in the file changed.

Code scanning / CodeQL

Modification of parameter with default Error

This expression mutates a
default value
.

Check failure on line 390 in src/sisl/viz/figure/plotly.py

See this annotation in the file changed.

Code scanning / CodeQL

Modification of parameter with default Error

This expression mutates a
default value
.
This expression mutates a
default value
.

Check notice on line 277 in src/sisl/viz/figure/blender.py

See this annotation in the file changed.

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.

Check notice on line 42 in src/sisl/viz/data/eigenstate.py

See this annotation in the file changed.

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.

Check notice on line 219 in src/sisl/viz/figure/matplotlib.py

See this annotation in the file changed.

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.

Check notice on line 445 in src/sisl/nodes/node.py

See this annotation in the file changed.

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.

Check notice on line 193 in src/sisl/viz/data/pdos.py

See this annotation in the file changed.

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.

Check notice on line 132 in src/sisl/viz/figure/plotly.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused local variable Note

Variable axes is not used.

Check notice on line 214 in src/sisl/viz/data/bands.py

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 474 in src/sisl/viz/figure/blender.py

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 519 in src/sisl/viz/figure/blender.py

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 57 in src/sisl/viz/figure/matplotlib.py

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check failure on line 7 in src/sisl/viz/processors/tests/test_data.py

See this annotation in the file changed.

Code scanning / CodeQL

Missing call to `__init__` during object initialization Error test

Class FakeData may not be initialized properly as
method Data.__init__
is not called from its
__init__ method
.

Check notice on line 428 in src/sisl/nodes/node.py

See this annotation in the file changed.

Code scanning / CodeQL

Cyclic import Note

Import of module
sisl.nodes.utils
begins an import cycle.

Check notice on line 1 in src/sisl/viz/data_sources/file/__init__.py

See this annotation in the file changed.

Code scanning / CodeQL

'import *' may pollute namespace Note

Import pollutes the enclosing namespace, as the imported module
sisl.viz.data_sources.file.file_source
does not define '__all__'.