Skip to content

Commit

Permalink
fix: Dockerfile linting errors
Browse files Browse the repository at this point in the history
  • Loading branch information
fbac committed Jul 25, 2024
1 parent a0c09ac commit f89228f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
12 changes: 6 additions & 6 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
FROM golang:alpine AS build-env

# Set up dependencies
ENV PACKAGES git build-base
ENV PACKAGES git build-base linux-headers

# Set working directory for the build
WORKDIR /go/src/github.com/zeta-chain/ethermint

# Install dependencies
RUN apk add --update $PACKAGES
RUN apk add linux-headers
# hadolint ignore=DL3018
RUN apk add --no-cache $PACKAGES

# Add source files
COPY . .
Expand All @@ -19,10 +18,11 @@ RUN make build
# Final image
FROM alpine:3.20.1

# Install ca-certificates
RUN apk add --update ca-certificates jq
WORKDIR /

# hadolint ignore=DL3018
RUN apk add --no-cache ca-certificates jq

# Copy over binaries from the build-env
COPY --from=build-env /go/src/github.com/zeta-chain/ethermint/build/ethermintd /usr/bin/ethermintd

Expand Down
5 changes: 4 additions & 1 deletion networks/local/ethermintnode/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@ FROM golang:stretch as build-env

# Install minimum necessary dependencies
ENV PACKAGES curl make git libc-dev bash gcc
RUN apt-get update && apt-get upgrade -y && \

# hadolint ignore=DL3018
RUN apt-get update && \
apt-get upgrade -y && \
apt-get install -y $PACKAGES

# Set working directory for the build
Expand Down

0 comments on commit f89228f

Please sign in to comment.