Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add eth_mainnet to networks #23

Merged
merged 1 commit into from
Sep 26, 2023
Merged

feat: Add eth_mainnet to networks #23

merged 1 commit into from
Sep 26, 2023

Conversation

andresaiello
Copy link
Collaborator

Summary

  • Add eth_mainnet to networks

fadeev
fadeev approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think at some point we might need to introduce a testnet property, though.

@andresaiello andresaiello merged commit e8471d6 into main Sep 26, 2023
4 checks passed
@andresaiello andresaiello deleted the andy/pd-4681-add-eth_mainnet-to-networks branch September 26, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadeev fadeev fadeev approved these changes

@lucas-janon lucas-janon Awaiting requested review from lucas-janon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andresaiello @fadeev