Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove ValidateBasic check in cli #1427

Merged

Conversation

lukema95
Copy link
Contributor

Description

The ValidateBasic function has been called in the GenerateOrBroadcastTxWithFactory function, so we no longer need to add the ValidateBasic function when writing Cli. Related PRs can be viewed at: cosmos/cosmos-sdk#9236 (comment)

Closes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@lukema95 lukema95 requested a review from fadeev as a code owner December 22, 2023 11:52
@lumtis lumtis merged commit 80afbe8 into zeta-chain:develop Jan 3, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants