Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrades #2101

Closed
wants to merge 4 commits into from
Closed

refactor: upgrades #2101

wants to merge 4 commits into from

Conversation

kingpinXD
Copy link
Contributor

@kingpinXD kingpinXD commented May 1, 2024

Description

Do Not merge

Closes:(#2077)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.96%. Comparing base (b460556) to head (41ff2cf).
Report is 4 commits behind head on develop.

❗ Current head 41ff2cf differs from pull request most recent head 0e86858. Consider uploading reports for the commit 0e86858 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2101      +/-   ##
===========================================
- Coverage    71.87%   69.96%   -1.91%     
===========================================
  Files          245      249       +4     
  Lines        13730    14040     +310     
===========================================
- Hits          9868     9823      -45     
- Misses        3405     3759     +354     
- Partials       457      458       +1     

see 32 files with indirect coverage changes

@lumtis lumtis mentioned this pull request May 2, 2024
8 tasks
@lumtis
Copy link
Member

lumtis commented May 7, 2024

What is the status on this @kingpinXD ?

@kingpinXD
Copy link
Contributor Author

What is the status on this @kingpinXD ?

The changes are finalized , we can test it once we have
#2122 , merged in

@kingpinXD kingpinXD closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants