Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 7.2 deprecation fixes #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

PHP 7.2 deprecation fixes #14

wants to merge 2 commits into from

Conversation

pbek
Copy link

@pbek pbek commented Sep 20, 2018

Fixes:

 PHP | File:Line                                                                                          |             Type | Issue
 7.0 | /tests/sqlabstraction/query_subselect_test.php:95                                                  | method_name      | Method name testSubSelect:TestSubSelect (@php4_constructors) is deprecated. 
 7.2 | /src/sqlabstraction/implementations/query_select_sqlite.php:174                                    | function         | Function each() is deprecated. 
 7.2 | /src/sqlabstraction/implementations/query_select_sqlite.php:177                                    | function         | Function each() is deprecated. 
 7.2 | /src/sqlabstraction/implementations/query_select_sqlite.php:179                                    | function         | Function each() is deprecated.

derickr
derickr requested changes Sep 20, 2018
View reviewed changes
Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Travis tests also fail, can you check that too?

tests/sqlabstraction/query_subselect_test.php Outdated Show resolved Hide resolved
src/sqlabstraction/implementations/query_select_sqlite.php Outdated Show resolved Hide resolved
@pbek
Copy link
Author

pbek commented Sep 21, 2018

All should be fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derickr derickr derickr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbek @derickr