Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

Fix syntax errors and obvious compile errors in README #153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sternenseemann
Copy link

This should improve documentation somewhat as the examples actually work
after being copy pasted.

Note that the example for closures isn't fixed in this commit as I
couldn't figure out how to fix it yet. See #152.

Copy link
Collaborator

@aep aep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

README.md Outdated
@@ -39,11 +39,11 @@ struct Random {
u32 num;
}

fn rng(Random *self) u32 {
fn rng(Random *self) -> u32 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the syntax for this has changed to remove the -> (golang style)
its just not disallowed yet.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the ->, the examples don't compile with zz 0.1 at the moment though.

Copy link
Collaborator

@aep aep Jan 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right. i should probably make http://bin.zetz.it/ more useful, and remove the github release to avoid confusion

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://bin.zetz.it/ now has less terrible sorting. please use the latest build from there

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you still intend to fix those?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed the amends I've made locally, but I'm not too motivated to compile every example manually again. I also don't know how to fix some examples (like the one with closures (#152) and the preprocessor one). Also #157 currently prevents me from building anything with dependencies.

You should be able to push to this branch, so maybe you can fix up the remainder.

This should improve documentation somewhat as the examples actually work
after being copy pasted.

Note that the example for closures isn't fixed in this commit as I
couldn't figure out how to fix it yet. See zetzit#152.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants