fix a test case

zhihengGet · Jul 17, 2024 · 12b0ed8 · 12b0ed8
1 parent 1274401
commit 12b0ed8
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 14 deletions.
diff --git a/packages/svelte-query-persist-client/tests/AwaitOnSuccess/AwaitOnSuccess.svelte b/packages/svelte-query-persist-client/tests/AwaitOnSuccess/AwaitOnSuccess.svelte
@@ -2,15 +2,15 @@
   import { createQuery } from '@tanstack/svelte-query'
   import { sleep } from '../utils'
 
-  export let key: Array<string>
-  export let states: Array<string>
+  let { key, states = $bindable() }: { key: string[]; states: string[] } =
+    $props()
 
   const state = createQuery({
     queryKey: key,
     queryFn: async () => {
-      states = [...states, 'fetching']
+      states.push('fetching')
       await sleep(10)
-      states = [...states, 'fetched']
+      states.push('fetched')
       return 'fetched'
     },
   })

diff --git a/packages/svelte-query-persist-client/tests/AwaitOnSuccess/Provider.svelte b/packages/svelte-query-persist-client/tests/AwaitOnSuccess/Provider.svelte
@@ -4,13 +4,23 @@
   import type { OmitKeyof, QueryClient } from '@tanstack/svelte-query'
   import type { PersistQueryClientOptions } from '@tanstack/query-persist-client-core'
 
-  export let queryClient: QueryClient
-  export let persistOptions: OmitKeyof<PersistQueryClientOptions, 'queryClient'>
-  export let key: Array<string>
-  export let onSuccess: () => Promise<void>
-  export let states: Array<string>
+  interface Props {
+    queryClient: QueryClient
+    persistOptions: OmitKeyof<PersistQueryClientOptions, 'queryClient'>
+    key: Array<string>
+    onSuccess: () => Promise<void>
+    states: Array<string>
+  }
+
+  let {
+    queryClient,
+    persistOptions,
+    key,
+    onSuccess,
+    states = $bindable(),
+  }: Props = $props()
 </script>
 
 <PersistQueryClientProvider client={queryClient} {persistOptions} {onSuccess}>
-  <AwaitOnSuccess {key} {states} />
+  <AwaitOnSuccess {key} bind:states />
 </PersistQueryClientProvider>
diff --git a/...PersistQueryClientProvider.svelte.test.ts → ...PersistQueryClientProvider.test.svelte.ts b/...PersistQueryClientProvider.svelte.test.ts → ...PersistQueryClientProvider.test.svelte.ts
@@ -302,7 +302,7 @@ describe('PersistQueryClientProvider', () => {
     await waitFor(() => rendered.getByText('fetched'))
   })
 
-  test('should await onSuccess after successful restoring', async () => {
+  test.only('should await onSuccess after successful restoring', async () => {
     const key = queryKey()
 
     const queryClient = createQueryClient()
@@ -326,9 +326,8 @@ describe('PersistQueryClientProvider', () => {
         key,
         states,
         onSuccess: async () => {
-          states = [...states, 'onSuccess']
-          await sleep(20)
-          states = [...states, 'onSuccess done']
+          states.push('onSuccess')
+          states.push('onSuccess done')
         },
       },
     })

diff --git a/packages/svelte-query-persist-client/vite.config.ts b/packages/svelte-query-persist-client/vite.config.ts
@@ -9,6 +9,7 @@ export default defineConfig({
     name: packageJson.name,
     dir: './tests',
     watch: false,
+    include: ['**/*.test.svelte.ts'],
     environment: 'jsdom',
     setupFiles: ['./tests/test-setup.ts'],
     coverage: { enabled: true, provider: 'istanbul', include: ['src/**/*'] },