Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Support for Partition Links #1685

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Support for Partition Links #1685

wants to merge 1 commit into from

Conversation

andy-maier
Copy link
Member

@andy-maier andy-maier commented Oct 5, 2024 •
edited
Loading

WIP TODOs:

  • Add example invocations to docstrings of:
    • create()
    • attach/detach()
  • Add end2end tests for partition attach/detach
  • Add end2end tests for list attached partitions
  • Add more testcases to end2end tests for create/delete
  • Move attach methods to Partition object

@andy-maier andy-maier self-assigned this Oct 5, 2024
@andy-maier andy-maier added this to the 1.19.0 milestone Oct 5, 2024
@andy-maier andy-maier linked an issue Oct 5, 2024 that may be closed by this pull request
Support for Partition Link resource #1678
Open
@andy-maier andy-maier force-pushed the andy/partition-link branch 2 times, most recently from e3498a8 to 3184b41 Compare October 24, 2024 08:24
@coveralls
Copy link
Collaborator

coveralls commented Oct 24, 2024 •
edited
Loading

Coverage Status

coverage: 81.628% (-0.8%) from 82.453%
when pulling eab61e3 on andy/partition-link
into f594a77 on master.

@andy-maier andy-maier force-pushed the andy/partition-link branch 3 times, most recently from 2a01040 to 15c7bf0 Compare October 25, 2024 15:17
@andy-maier
Support for Partition Links
eab61e3 
Signed-off-by: Andreas Maier <[email protected]>
simon-spinner
simon-spinner reviewed Nov 7, 2024
View reviewed changes
zhmcclient/_partition_link.py
self, partition, properties, wait_for_completion=True,
operation_timeout=None):
"""
Attach this partition link to a partition, creating corresponding
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the attach tape link/storage group operations on the Partition resource. I am wondering whether it makes sense to move the attach partition link operation there as well for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-spinner simon-spinner simon-spinner left review comments

Assignees

@andy-maier andy-maier

Labels
under work
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.

Support for Partition Link resource
3 participants
@andy-maier @coveralls @simon-spinner