Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Started using the trusted publisher concept of Pypi #1693

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ jobs:
name: Build and publish to PyPI
if: startsWith(github.ref, 'refs/tags')
runs-on: ubuntu-latest
permissions:
id-token: write
contents: write
steps:

#-------- Info gathering and checks
Expand Down Expand Up @@ -144,7 +147,8 @@ jobs:
uses: pypa/gh-action-pypi-publish@release/v1
with:
packages-dir: dist
password: ${{ secrets.PYPI_API_TOKEN }}
# Pypi has a trusted publisher defined, so we do not need a password:
# https://pypi.org/manage/project/zhmcclient/settings/publishing/

#-------- Creation of Github release
- name: Determine whether release on Github exists for the pushed tag
Expand Down
2 changes: 2 additions & 0 deletions changes/noissue.2.cleanup.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Dev: Started using the trusted publisher concept of Pypi in order to avoid
dealing with Pypi access tokens.