add search latency metrics for grafana

Signed-off-by: Wei Liu <[email protected]>
zilliztech · Aug 31, 2023 · 73452cf · 73452cf
1 parent 4176a66
commit 73452cf
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 4 deletions.
diff --git a/include/knowhere/prometheus_client.h b/include/knowhere/prometheus_client.h
@@ -78,5 +78,6 @@ DECLARE_PROMETHEUS_COUNTER(knowhere_build_count);
 DECLARE_PROMETHEUS_COUNTER(knowhere_search_count);
 DECLARE_PROMETHEUS_COUNTER(knowhere_range_search_count);
 DECLARE_PROMETHEUS_HISTOGRAM(knowhere_search_topk);
-
+DECLARE_PROMETHEUS_HISTOGRAM(knowhere_search_latency);
+DECLARE_PROMETHEUS_HISTOGRAM(knowhere_range_search_latency);
 }  // namespace knowhere
diff --git a/src/common/index.cc b/src/common/index.cc
@@ -10,7 +10,7 @@
 // or implied. See the License for the specific language governing permissions and limitations under the License.
 
 #include "knowhere/index.h"
-
+#include "knowhere/comp/time_recorder.h"
 #include "knowhere/dataset.h"
 #include "knowhere/expected.h"
 #include "knowhere/log.h"
@@ -75,10 +75,17 @@ Index<T>::Search(const DataSet& dataset, const Json& json, const BitsetView& bit
     }
 
 #ifdef NOT_COMPILE_FOR_SWIG
+    TimeRecorder rc("Search");
+    auto res = this->node->Search(dataset, *cfg, bitset);
+    auto span = rc.ElapseFromBegin("done");
+    span *= 0.001;  // convert to ms
+    knowhere_search_latency.Observe(span);
     knowhere_search_count.Increment();
     knowhere_search_topk.Observe(cfg->k.value());
+#else
+    auto res = this->node->Search(dataset, *cfg, bitset);
 #endif
-    return this->node->Search(dataset, *cfg, bitset);
+    return res;
 }
 
 template <typename T>
@@ -96,9 +103,16 @@ Index<T>::RangeSearch(const DataSet& dataset, const Json& json, const BitsetView
     }
 
 #ifdef NOT_COMPILE_FOR_SWIG
+    TimeRecorder rc("Range Search");
+    auto res = this->node->RangeSearch(dataset, *cfg, bitset);
+    auto span = rc.ElapseFromBegin("done");
+    span *= 0.001;  // convert to ms
+    knowhere_range_search_latency.Observe(span);
     knowhere_range_search_count.Increment();
+#else
+    auto res = this->node->RangeSearch(dataset, *cfg, bitset);
 #endif
-    return this->node->RangeSearch(dataset, *cfg, bitset);
+    return res;
 }
 
 template <typename T>

diff --git a/src/common/prometheus_client.cc b/src/common/prometheus_client.cc
@@ -29,5 +29,7 @@ DEFINE_PROMETHEUS_COUNTER(knowhere_build_count, "knowhere index build count")
 DEFINE_PROMETHEUS_COUNTER(knowhere_search_count, "knowhere search count")
 DEFINE_PROMETHEUS_COUNTER(knowhere_range_search_count, "knowhere range search count")
 DEFINE_PROMETHEUS_HISTOGRAM(knowhere_search_topk, "knowhere search topk")
+DEFINE_PROMETHEUS_HISTOGRAM(knowhere_search_latency, "search latency in knowhere (ms)")
+DEFINE_PROMETHEUS_HISTOGRAM(knowhere_range_search_latency, "range search latency in knowhere (ms)")
 
 }  // namespace knowhere