Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine DiskANN AIO Parameters #7

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Refine DiskANN AIO Parameters #7

merged 1 commit into from
Aug 11, 2023

Conversation

PwzXxm
Copy link
Collaborator

@PwzXxm PwzXxm commented Aug 10, 2023 •
edited
Loading

issue: #6

This PR sets the default_max_nr to be half of the MAX_N_SECTOR_READS, and removes max_events parameter from the SetAioContextPool() function.

@mergify mergify bot added the dco-passed label Aug 10, 2023
@PwzXxm PwzXxm mentioned this pull request Aug 10, 2023
Closed
1 task
@PwzXxm PwzXxm force-pushed the refine_diskann_aio_param branch 2 times, most recently from a74a007 to a55e49f Compare August 10, 2023 11:33
liliu-z
liliu-z approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@PwzXxm
Copy link
Collaborator Author

PwzXxm commented Aug 11, 2023

/hold

@PwzXxm
Refine DiskANN AIO Parameters
010e26e 
Signed-off-by: Patrick Weizhi Xu <[email protected]>
@sre-ci-robot sre-ci-robot removed the lgtm label Aug 11, 2023
@liliu-z
Copy link
Collaborator

liliu-z commented Aug 11, 2023

/lgtm
/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, PwzXxm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PwzXxm
Copy link
Collaborator Author

PwzXxm commented Aug 11, 2023

/unhold

@liliu-z liliu-z merged commit aa4a42f into zilliztech:main Aug 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liliu-z liliu-z liliu-z approved these changes

@cqy123456 cqy123456 Awaiting requested review from cqy123456

@zhengbuqian zhengbuqian Awaiting requested review from zhengbuqian

Assignees

@liliu-z liliu-z

Labels
approved dco-passed lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PwzXxm @liliu-z @sre-ci-robot