Update test_simd #867
Update test_simd #867
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cydrain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cydrain 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
cydrain
force-pushed
the
caiyd_add_simd_ut
branch
from
812e0f9
to
a62c3a3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #867 +/- ##
=========================================
+ Coverage 0 77.57% +77.57%
=========================================
Files 0 86 +86
Lines 0 6216 +6216
=========================================
+ Hits 0 4822 +4822
- Misses 0 1394 +1394 |
cydrain
force-pushed
the
caiyd_add_simd_ut
branch
from
a62c3a3
to
ddee71c
Compare
|
/kind improvement |
| auto dim = GENERATE(as<size_t>{}, 1, 7, 14, 21, 28, 35, 42, 49, 56, 64, 128, 256, 512); | ||
|
|
||
| LOG_KNOWHERE_INFO_ << "simd type: " << simd_type << ", dim: " << dim; | ||
| knowhere::KnowhereConfig::SetSimdType(simd_type); |
There was a problem hiding this comment.
what happens if this unit test is run on ARM machine?
There was a problem hiding this comment.
I'll test it tomorrow
There was a problem hiding this comment.
Run in arm, this case can pass
Signed-off-by: Cai Yudong <[email protected]>
cydrain
force-pushed
the
caiyd_add_simd_ut
branch
from
ddee71c
to
fb5fd9e
Compare
|
Overall coverage rate: |
|
/lgtm |
issue: #809