-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Update default thread priority #868
enhance: Update default thread priority #868
Conversation
Welcome @congqixia! It looks like this is your first PR to zilliztech/knowhere 🎉 |
@congqixia 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
/kind improvement |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #868 +/- ##
=========================================
+ Coverage 0 77.68% +77.68%
=========================================
Files 0 85 +85
Lines 0 6390 +6390
=========================================
+ Hits 0 4964 +4964
- Misses 0 1426 +1426 |
/lgtm wait for ci pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plz squash the commit to unify the msgs, @congqixia
Related to milvus-io/milvus#36513 Change default priority to 10 and add fallback & range check logic Signed-off-by: Congqi Xia <[email protected]>
13c845e
to
1ca30b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, liliu-z The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related to milvus-io/milvus#36513