Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Update default thread priority #868

Merged

Conversation

congqixia
Copy link
Contributor

@sre-ci-robot
Copy link
Collaborator

Welcome @congqixia! It looks like this is your first PR to zilliztech/knowhere 🎉

Copy link

mergify bot commented Sep 25, 2024

@congqixia 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@congqixia
Copy link
Contributor Author

/kind improvement

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.68%. Comparing base (3c46f4c) to head (1ca30b4).
Report is 209 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #868       +/-   ##
=========================================
+ Coverage      0   77.68%   +77.68%     
=========================================
  Files         0       85       +85     
  Lines         0     6390     +6390     
=========================================
+ Hits          0     4964     +4964     
- Misses        0     1426     +1426     

see 85 files with indirect coverage changes

@zhengbuqian
Copy link
Collaborator

/lgtm

wait for ci pass

Copy link
Collaborator

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz squash the commit to unify the msgs, @congqixia

Related to milvus-io/milvus#36513

Change default priority to 10 and add fallback & range check logic

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia force-pushed the enhance/change_default_thread_priority branch from 13c845e to 1ca30b4 Compare September 26, 2024 10:08
Copy link
Collaborator

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liliu-z liliu-z merged commit 7c75d65 into zilliztech:main Sep 26, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants