Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix async bug #889

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix async bug #889

merged 1 commit into from
Oct 16, 2024

Conversation

Presburger
Copy link
Collaborator

@Presburger Presburger commented Oct 14, 2024

@alexanderguzhva help review

Signed-off-by: yusheng.ma <[email protected]>
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Presburger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

mergify bot commented Oct 14, 2024

@Presburger 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.52%. Comparing base (3c46f4c) to head (0bbc24c).
Report is 221 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #889       +/-   ##
=========================================
+ Coverage      0   77.52%   +77.52%     
=========================================
  Files         0       85       +85     
  Lines         0     6376     +6376     
=========================================
+ Hits          0     4943     +4943     
- Misses        0     1433     +1433     

see 85 files with indirect coverage changes

@alexanderguzhva
Copy link
Collaborator

/lgtm
@Presburger Personally, I would use std::shared_ptr<Json> to avoid copying, but passing just json is fine as well.

@Presburger
Copy link
Collaborator Author

/lgtm @Presburger Personally, I would use std::shared_ptr<Json> to avoid copying, but passing just json is fine as well.

Alex, your suggestion is correct, but changing it to shared_ptr would require quite a few API modifications. 😂

@Presburger
Copy link
Collaborator Author

issue: #890

@Presburger
Copy link
Collaborator Author

/kind enhancement

@sre-ci-robot sre-ci-robot merged commit 0a30859 into zilliztech:main Oct 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants