-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update dim
config & fix msg nullpointer error
#903
Conversation
@foxspy 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
/kind improvement |
src/index/hnsw/faiss_hnsw_config.h
Outdated
*err_msg = "refine is not supported for this index"; | ||
if (err_msg) { | ||
*err_msg = "refine is not supported for this index"; | ||
} | ||
LOG_KNOWHERE_ERROR_ << *err_msg; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be inside if (err_msg)
Signed-off-by: foxspy <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderguzhva, foxspy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #903 +/- ##
=========================================
+ Coverage 0 79.30% +79.30%
=========================================
Files 0 81 +81
Lines 0 6316 +6316
=========================================
+ Hits 0 5009 +5009
- Misses 0 1307 +1307 |
issue: #795