Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update dim config & fix msg nullpointer error #903

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

foxspy
Copy link
Collaborator

@foxspy foxspy commented Oct 18, 2024

issue: #795

Copy link

mergify bot commented Oct 18, 2024

@foxspy 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@foxspy
Copy link
Collaborator Author

foxspy commented Oct 18, 2024

/kind improvement

*err_msg = "refine is not supported for this index";
if (err_msg) {
*err_msg = "refine is not supported for this index";
}
LOG_KNOWHERE_ERROR_ << *err_msg;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be inside if (err_msg)

Signed-off-by: foxspy <[email protected]>
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexanderguzhva
Copy link
Collaborator

/lgtm

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.30%. Comparing base (3c46f4c) to head (73316f7).
Report is 226 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #903       +/-   ##
=========================================
+ Coverage      0   79.30%   +79.30%     
=========================================
  Files         0       81       +81     
  Lines         0     6316     +6316     
=========================================
+ Hits          0     5009     +5009     
- Misses        0     1307     +1307     

see 81 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Oct 18, 2024
@sre-ci-robot sre-ci-robot merged commit 616f5e3 into zilliztech:main Oct 18, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants